fix(j-s): Fix e2e test #16227
fix(j-s): Fix e2e test #16227
Conversation
WalkthroughThe pull request introduces updates to the custody tests within the judicial system's end-to-end testing suite. Key modifications involve changing input field identifiers, streamlining the judge's decision submission process, confirming the defender's statement submission, and elaborating on the prosecutor's extension request. The overall flow of actions among the prosecutor, judge, defender, and court of appeals judge has been maintained to ensure consistency with the updated case handling logic. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/system-e2e/src/tests/judicial-system/regression/custody-tests.spec.ts (1)
71-73: Consider usingdata-testidattributes for selectorsReliance on IDs in selectors can lead to brittle tests if the HTML structure changes. Using
data-testidattributes specifically designed for testing can make your tests more robust and maintainable.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- apps/system-e2e/src/tests/judicial-system/regression/custody-tests.spec.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
apps/system-e2e/src/tests/judicial-system/regression/custody-tests.spec.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (1)
apps/system-e2e/src/tests/judicial-system/regression/custody-tests.spec.ts (1)
71-73: LGTM!The input field identifiers have been correctly updated from
defenderNametoadvocateName, aligning with the changes made in PR #16087.
Datadog ReportAll test runs ✅ 74 Total Test Services: 0 Failed, 72 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (4) |
Fix e2e test
Asana
What
Update query selector to match the changes made in #16087.
Why
So that e2e tests will run.
Checklist:
Summary by CodeRabbit